[
https://issues.apache.org/jira/browse/HBASE-20507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459689#comment-16459689
]
stack commented on HBASE-20507:
-------------------------------
So, IIUC, this is different to what I see over in HBASE-20503 where I am
writing a WAL and then it breaks ("Stream already broken"). In this case we
roll the WAL and try to recover the file we had been writing too -- the one
that was reporting "stream already broken" -- in the stream's recoverAndClose.
Do we need to recover the lease in recoverAndClose?
On this patch, LGTM. Nice test. On the javac warning, I don't know how to
avoid. Perhaps someone else does. Meantime push it I'd say.
> Do not need to call recoverLease on the broken file when we fail to create a
> wal writer
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-20507
> URL: https://issues.apache.org/jira/browse/HBASE-20507
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 2.0.1
>
> Attachments: HBASE-20507.patch
>
>
> I tried locally with a UT, if we overwrite a file which is currently being
> written, the old file will be completed and then deleted. If you call close
> on the previous file, a no lease exception will be thrown which means that
> the file has already been completed.
> So we do not need to close a file if it will be overwritten immediately,
> since recoverLease may take a very long time...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
