[
https://issues.apache.org/jira/browse/HBASE-20169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460211#comment-16460211
]
stack commented on HBASE-20169:
-------------------------------
A few notes (sorry for taking so long to come back to hear -- I just noticed
this test still fails...)
* Nice digging [~chia7712].
* Yeah, I don't get how #join runs before #stop. Looking in code its always
after a #stop. The PE#stop has an atomic #running that is checked and set on
entrance so we should run #stop once. Pardon me for being thick.
* Setting timeoutExecutor to null seems gratuitous. It was added in
HBASE-16846 "Procedure v2 - executor cleanup"... From the description "Trying
to reorganize the executor. move some code around grouping common code, remove
some synchronization from Procedure and adding comments on various sections.
The execution logic remains unchanged": i.e. general cleanup. Lets remove
setting it to null. A #join shoud be an observer, not a modifier.
* Regards, "BTW, the NPE is not related to this issue.", I'd say lets fix test
and this issue in here... beside this good discussion.
Let me update your amendment [~chia7712]
> NPE when calling HBTU.shutdownMiniCluster (TestAssignmentManagerMetrics is
> flakey)
> ----------------------------------------------------------------------------------
>
> Key: HBASE-20169
> URL: https://issues.apache.org/jira/browse/HBASE-20169
> Project: HBase
> Issue Type: Bug
> Components: test
> Reporter: Duo Zhang
> Assignee: stack
> Priority: Major
> Attachments: HBASE-20169.branch-2.001.patch,
> HBASE-20169.branch-2.002.patch, HBASE-20169.branch-2.003.patch,
> HBASE-20169.branch-2.004.patch, HBASE-20169.branch-2.005.patch,
> HBASE-20169.v0.addendum.patch
>
>
> This usually happens when some master or rs has already been down before we
> calling shutdownMiniCluster.
> See
> https://builds.apache.org/job/HBASE-Flaky-Tests/27223/testReport/junit/org.apache.hadoop.hbase.master/TestAssignmentManagerMetrics/org_apache_hadoop_hbase_master_TestAssignmentManagerMetrics/
> and also
> http://104.198.223.121:8080/job/HBASE-Flaky-Tests/34873/testReport/junit/org.apache.hadoop.hbase.master/TestRestartCluster/testRetainAssignmentOnRestart/
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics.after(TestAssignmentManagerMetrics.java:100)
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.master.TestRestartCluster.testRetainAssignmentOnRestart(TestRestartCluster.java:156)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
