[
https://issues.apache.org/jira/browse/HBASE-5166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213139#comment-13213139
]
Zhihong Yu commented on HBASE-5166:
-----------------------------------
@Jai:
{code}
+ * Copyright 2007 The Apache Software Foundation
{code}
Year is not needed in license header. Same here:
{code}
+ * Copyright 2009 The Apache Software Foundation
{code}
{code}
+ public void testAddDependencyJars() throws Exception {
{code}
The above doesn't carry @Test annotation. If it is not needed for this JIRA,
please remove it.
{code}
+ public static final String MAPPER_CLASS =
"hbase.mapreduce.multithreadedrunner.class";
{code}
I think the name of config parameter should be changed to
'multithreadedmapper.class'
Same for NUMBER_OF_THREADS
{code}
+ private class SubMapRecordReader extends
RecordReader<ImmutableBytesWritable, Result> {
{code}
Why do we need the Sub prefix above ?
Putting the patch on https://reviews.apache.org would make review process
smooth.
> MultiThreaded Table Mapper analogous to MultiThreaded Mapper in hadoop
> ----------------------------------------------------------------------
>
> Key: HBASE-5166
> URL: https://issues.apache.org/jira/browse/HBASE-5166
> Project: HBase
> Issue Type: Improvement
> Reporter: Jai Kumar Singh
> Priority: Minor
> Labels: multithreaded, tablemapper
> Attachments: 0001-Added-MultithreadedTableMapper-HBASE-5166.patch,
> 0003-Added-MultithreadedTableMapper-HBASE-5166.patch,
> 0005-HBASE-5166-Added-MultithreadedTableMapper.patch,
> 0006-HBASE-5166-Added-MultithreadedTableMapper.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> There is no MultiThreadedTableMapper in hbase currently just like we have a
> MultiThreadedMapper in Hadoop for IO Bound Jobs.
> UseCase, webcrawler: take input (urls) from a hbase table and put the content
> (urls, content) back into hbase.
> Running these kind of hbase mapreduce job with normal table mapper is quite
> slow as we are not utilizing CPU fully (N/W IO Bound).
> Moreover, I want to know whether It would be a good/bad idea to use HBase for
> these kind of usecases ?.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
