[
https://issues.apache.org/jira/browse/HBASE-20653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492882#comment-16492882
]
Nihal Jain edited comment on HBASE-20653 at 5/28/18 6:53 PM:
-------------------------------------------------------------
Please review [^HBASE-20653.master.001.patch] .
We have a public method {{checkPermission}} in {{RSGroupAdminEndpoint}} which
becomes redundant after this patch. Haven't removed it though; let me know if I
should do something about it.
Also, I have added {{preListRSGroupInfos & }}{{postListRSGroupInfos;}} not
{{preListRSGroup & }}{{postListRSGroup}}. Let me know if this needs to be done
the other way around.
was (Author: nihaljain.cs):
Please review [^HBASE-20653.master.001.patch] .
We have a public method {{checkPermission}} in {{RSGroupAdminEndpoint}} which
becomes redundant after this patch. Haven't removed it though; let me know if I
should do something about it.
> Add missing observer hooks for region server group to MasterObserver
> --------------------------------------------------------------------
>
> Key: HBASE-20653
> URL: https://issues.apache.org/jira/browse/HBASE-20653
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Nihal Jain
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20653.master.001.patch
>
>
> Currently the following region server group operations don't have
> corresponding hook in MasterObserver :
> * getRSGroupInfo
> * getRSGroupInfoOfServer
> * getRSGroupInfoOfTable
> * listRSGroup
> This JIRA is to
> * add them to MasterObserver
> * add corresponding permission check in AccessController
> * move the {{checkPermission}} out of RSGroupAdminEndpoint
> * add corresponding tests to TestRSGroupsWithACL
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
