[
https://issues.apache.org/jira/browse/HBASE-20653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493644#comment-16493644
]
Nihal Jain edited comment on HBASE-20653 at 5/29/18 2:57 PM:
-------------------------------------------------------------
[^HBASE-20653.master.002.patch] This patch takes care of the following:
* Fixes doc-string problem
* Removes redundant method {{checkPermission}}
* Adds new tests in {{TestRSGroups }} to validate the CP hooks are called
Still need to figure out why tests failed in {{TestRSGroups}} in
[^HBASE-20653.master.001.patch]}}
was (Author: nihaljain.cs):
[^HBASE-20653.master.002.patch] This patch takes care of the following:
* Fixes doc-string problem
* Removes redundant method {{checkPermission}}
* Adds new tests in {{TestRSGroups }}to validate the CP hooks are called
Still need to figure out why tests failed in {{TestRSGroups in
[^HBASE-20653.master.001.patch]}}
> Add missing observer hooks for region server group to MasterObserver
> --------------------------------------------------------------------
>
> Key: HBASE-20653
> URL: https://issues.apache.org/jira/browse/HBASE-20653
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Nihal Jain
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20653.master.001.patch,
> HBASE-20653.master.002.patch
>
>
> Currently the following region server group operations don't have
> corresponding hook in MasterObserver :
> * getRSGroupInfo
> * getRSGroupInfoOfServer
> * getRSGroupInfoOfTable
> * listRSGroup
> This JIRA is to
> * add them to MasterObserver
> * add corresponding permission check in AccessController
> * move the {{checkPermission}} out of RSGroupAdminEndpoint
> * add corresponding tests to TestRSGroupsWithACL
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)