[
https://issues.apache.org/jira/browse/HBASE-19761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493378#comment-16493378
]
Jan Hentschel commented on HBASE-19761:
---------------------------------------
[~maoling] I had a look at v3. LGTM overall. I have some small comments
regarding some parts of the documentation.
* In {{ZKWatcher}} lines 98 and 114: please use "ZooKeeper" instead of
"zookeeper".
* In {{ZKMainServer}} lines 60-62: The comments are too general. Because the
exceptions come from {{ZooKeeperMain.processCmd}} it should be sufficient to
copy the exception documentation from there.
As a general comment: Please also create a review request on [Apache
Reviews|https://reviews.apache.org/] for additional submissions. This will ease
the review process.
> Fix Checkstyle errors in hbase-zookeeper
> ----------------------------------------
>
> Key: HBASE-19761
> URL: https://issues.apache.org/jira/browse/HBASE-19761
> Project: HBase
> Issue Type: Sub-task
> Reporter: Jan Hentschel
> Assignee: maoling
> Priority: Minor
> Attachments: HBASE-19761-master-v0.patch,
> HBASE-19761-master-v1.patch, HBASE-19761-master-v2.patch,
> HBASE-19761-master-v3.patch
>
>
> Fix the remaining Checkstyle errors in the *hbase-zookeeper* module and
> enable Checkstyle to fail on violations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
