[
https://issues.apache.org/jira/browse/HBASE-19761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493693#comment-16493693
]
Jan Hentschel commented on HBASE-19761:
---------------------------------------
Thanks [~maoling]. When running it locally, Checkstyle complains about the
following things:
{code}
[INFO] --- maven-checkstyle-plugin:3.0.0:check (checkstyle) @ hbase-zookeeper
---
[INFO] There are 49 errors reported by Checkstyle 8.2 with hbase/checkstyle.xml
ruleset.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/ZKNodeTracker.java:[105]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterStatusTracker.java:[68]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterStatusTracker.java:[82]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/LoadBalancerTracker.java:[85]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKMainServer.java:[49]
(indentation) Indentation: 'throws' has incorrect indentation level 4, expected
level should be 6.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java:[88]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java:[97]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java:[303]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java:[334]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java:[365]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java:[398]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java:[448]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java:[479]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java:[522]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java:[590]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java:[656]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKClusterId.java:[64]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java:[211]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java:[118]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[111]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[118]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[124]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[350]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[404]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[441]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[496]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[553]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[585]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[636]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[698]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[804]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[848]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[853]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[962]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[1002]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[1069]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[1135]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[1141]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[1176]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[1194]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[1219]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[1229]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[1249]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[1275]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR] src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[1948]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/MetaTableLocator.java:[194]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/MetaTableLocator.java:[212]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/MetaTableLocator.java:[536]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
[ERROR]
src/main/java/org/apache/hadoop/hbase/zookeeper/MetaTableLocator.java:[541]
(indentation) Indentation: 'throws' has incorrect indentation level 2, expected
level should be 4.
{code}
Could you please take a look at it? Seems only be indentation things. I also
left minor comments about the documentation in the review request.
> Fix Checkstyle errors in hbase-zookeeper
> ----------------------------------------
>
> Key: HBASE-19761
> URL: https://issues.apache.org/jira/browse/HBASE-19761
> Project: HBase
> Issue Type: Sub-task
> Reporter: Jan Hentschel
> Assignee: maoling
> Priority: Minor
> Attachments: HBASE-19761-master-v0.patch,
> HBASE-19761-master-v1.patch, HBASE-19761-master-v2.patch,
> HBASE-19761-master-v3.patch, HBASE-19761.master.001.patch
>
>
> Fix the remaining Checkstyle errors in the *hbase-zookeeper* module and
> enable Checkstyle to fail on violations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
