[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493549#comment-16493549
]
Sean Busbey commented on HBASE-20478:
-------------------------------------
{code}
diff --git
a/hbase-endpoint/src/main/java/org/apache/hadoop/hbase/security/access/SecureBulkLoadEndpoint.java
b/hbase-endpoint/src/main/java/org/apache/hadoop/hbase/security/access/SecureBulkLoadEndpoint.java
index a603ef14f2..23c0f02cfa 100644
---
a/hbase-endpoint/src/main/java/org/apache/hadoop/hbase/security/access/SecureBulkLoadEndpoint.java
+++
b/hbase-endpoint/src/main/java/org/apache/hadoop/hbase/security/access/SecureBulkLoadEndpoint.java
@@ -120,10 +120,6 @@ public class SecureBulkLoadEndpoint extends
SecureBulkLoadService implements Reg
done.run(null);
}
- /**
- * Convert from CPEP protobuf 2.5 to internal protobuf 3.3.
- * @throws
org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException
- */
org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos.CleanupBulkLoadRequest
convert(CleanupBulkLoadRequest request)
throws
org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException {
{code}
Why the removal of the entire comment? (I get removing the \@throws clause
since it doesn't say anything.)
> move import checks from hbaseanti to checkstyle
> -----------------------------------------------
>
> Key: HBASE-20478
> URL: https://issues.apache.org/jira/browse/HBASE-20478
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Sean Busbey
> Assignee: Mike Drob
> Priority: Minor
> Attachments: HBASE-20478.0.patch, HBASE-20478.1.patch,
> HBASE-20478.2.patch, HBASE-20478.3.patch, HBASE-20478.4.patch,
> HBASE-20478.5.patch, HBASE-20478.6.patch, HBASE-20478.8.patch,
> HBASE-20478.WIP.2.patch, HBASE-20478.WIP.2.patch, HBASE-20478.WIP.patch,
> HBASE-anti-check.patch
>
>
> came up in discussion on HBASE-20332. our check of "don't do this" things in
> the codebase doesn't log the specifics of complaints anywhere, which forces
> those who want to follow up to reverse engineer the check.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
