[ https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493642#comment-16493642 ]
Sean Busbey commented on HBASE-20478: ------------------------------------- okay. I'd rather have that kind of comment still in place (or maybe just a class level explanation?), since I don't think it's immediately obvious what's going on. I'm +1 on v8, either as-is or with the comment restored. > move import checks from hbaseanti to checkstyle > ----------------------------------------------- > > Key: HBASE-20478 > URL: https://issues.apache.org/jira/browse/HBASE-20478 > Project: HBase > Issue Type: Improvement > Components: test > Reporter: Sean Busbey > Assignee: Mike Drob > Priority: Minor > Attachments: HBASE-20478.0.patch, HBASE-20478.1.patch, > HBASE-20478.2.patch, HBASE-20478.3.patch, HBASE-20478.4.patch, > HBASE-20478.5.patch, HBASE-20478.6.patch, HBASE-20478.8.patch, > HBASE-20478.WIP.2.patch, HBASE-20478.WIP.2.patch, HBASE-20478.WIP.patch, > HBASE-anti-check.patch > > > came up in discussion on HBASE-20332. our check of "don't do this" things in > the codebase doesn't log the specifics of complaints anywhere, which forces > those who want to follow up to reverse engineer the check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)