[ 
https://issues.apache.org/jira/browse/HBASE-20334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502146#comment-16502146
 ] 

Sean Busbey commented on HBASE-20334:
-------------------------------------

{quote}
bq. /path/to/component/bin-install
You mean the HBase installation by this? (the unpacked HBase binary tarball)
{quote}

yes.

{quote}
{code}
+  <property>
+    <name>hbase.rootdir</name>
+    <!-- We rely on the defaultFS being set in our hadoop confs -->
+    <value>/hbase</value>
+  </property>
{code}
Double-checking, the script is always starting up a minicluster – never trying 
to use an existing HDFS installation?
{quote}

Yes, this is currently an end-to-end test. I could adapt it to optionally use 
an existing cluster.

{quote}
{code}
+yarn_server_tests_test_jar="$3"
+mapred_jobclient_test_jar="$4"
{code}
Could add some bash "is file" conditional checks on these two.
{quote}

will do.

{quote}
I'm sure you would've done this on your own already if there was an easy way, 
but is there a way we could avoid generated the TSV data and the Java file at 
the end of the script?
{quote}

I could structure things differently by putting this test into its own folder 
and including them as resources there. The down side is that the script will no 
longer be self contained. At this point I don't have a strong feeling either 
way.

> add a test that expressly uses both our shaded client and the one from hadoop 
> 3
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-20334
>                 URL: https://issues.apache.org/jira/browse/HBASE-20334
>             Project: HBase
>          Issue Type: Sub-task
>          Components: hadoop3, shading
>    Affects Versions: 2.0.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Major
>         Attachments: HBASE-20334.0.patch
>
>
> Since we're making a shaded client that bleed out of our namespace and into 
> Hadoop's, we should ensure that we can show our clients coexisting. Even if 
> it's just an IT that successfully talks to both us and HDFS via our 
> respective shaded clients, that'd be a big help in keeping us proactive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to