[ 
https://issues.apache.org/jira/browse/HBASE-20334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502155#comment-16502155
 ] 

Josh Elser commented on HBASE-20334:
------------------------------------

{quote}Yes, this is currently an end-to-end test. I could adapt it to 
optionally use an existing cluster.
{quote}
My only concern was using a top-level directory in HDFS if it was a "secure" 
instance. That would very likely require HDFS superuser access to create. If 
we're using a minicluster only, that's perfectly fine (I think supporting a 
real hdfs complicates this unnecessarily).
{quote}I could structure things differently by putting this test into its own 
folder and including them as resources there. The down side is that the script 
will no longer be self contained. At this point I don't have a strong feeling 
either way.
{quote}
Yeah, I feel you. I didn't know of any bash "magic" that we could do which 
would still give us a self-contained "unit" as you've created now. No strong 
feelings from me either. I think what you have now is great.

> add a test that expressly uses both our shaded client and the one from hadoop 
> 3
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-20334
>                 URL: https://issues.apache.org/jira/browse/HBASE-20334
>             Project: HBase
>          Issue Type: Sub-task
>          Components: hadoop3, shading
>    Affects Versions: 2.0.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Major
>         Attachments: HBASE-20334.0.patch
>
>
> Since we're making a shaded client that bleed out of our namespace and into 
> Hadoop's, we should ensure that we can show our clients coexisting. Even if 
> it's just an IT that successfully talks to both us and HDFS via our 
> respective shaded clients, that'd be a big help in keeping us proactive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to