[
https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502562#comment-16502562
]
Ted Yu commented on HBASE-20683:
--------------------------------
lgtm
{code}
* @return DataBlockEncoding compatible with HBase 2
* @throws IOException if a remote or network exception occurs
*/
private boolean validateDBE() throws IOException {
{code}
I wonder if the return value should be int: the number of incompatibilities (0
means pass).
> Incorrect return value for PreUpgradeValidator
> ----------------------------------------------
>
> Key: HBASE-20683
> URL: https://issues.apache.org/jira/browse/HBASE-20683
> Project: HBase
> Issue Type: Bug
> Affects Versions: 3.0.0, 2.1.0, 2.0.1
> Reporter: Peter Somogyi
> Assignee: Peter Somogyi
> Priority: Critical
> Attachments: HBASE-20683.master.001.patch
>
>
> PreUpgradeValidator currently returns 1 when there is no incompatibilities.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
