[ 
https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503348#comment-16503348
 ] 

Chia-Ping Tsai commented on HBASE-20683:
----------------------------------------

{quote}Do you think it is not a good idea to return the number of incompatible 
column families?
{quote}
Returning the number of incompatible column families makes sense to me. I 
didn't review the patch by the IDE so I misunderstand the purpose of the patch. 
(I assumed the patch is used to the enhance or fix the tool...)
{quote}Currently we don't use the value just to check if it is zero or not, but 
later on we could build a report of all the pre-upgrade validations where this 
number could be useful.
{quote}
+1 on your idea and patch.

 

 

> Incorrect return value for PreUpgradeValidator
> ----------------------------------------------
>
>                 Key: HBASE-20683
>                 URL: https://issues.apache.org/jira/browse/HBASE-20683
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 2.1.0, 2.0.1
>            Reporter: Peter Somogyi
>            Assignee: Peter Somogyi
>            Priority: Critical
>         Attachments: HBASE-20683.master.001.patch, 
> HBASE-20683.master.002.patch
>
>
> PreUpgradeValidator currently returns 1 when there is no incompatibilities.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to