[
https://issues.apache.org/jira/browse/HBASE-20665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504750#comment-16504750
]
Sean Busbey commented on HBASE-20665:
-------------------------------------
{quote}
-1 test4tests 0m 0s The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch.
{quote}
Sadly we have no easy way to add tests of logging, so I don't think we need one
here.
+1. will merge later today based on PR#77 (for e.g. authorship).
> "Already cached block XXX" message should be DEBUG
> --------------------------------------------------
>
> Key: HBASE-20665
> URL: https://issues.apache.org/jira/browse/HBASE-20665
> Project: HBase
> Issue Type: Task
> Components: BlockCache
> Affects Versions: 1.2.0, 2.0.0
> Reporter: Sean Busbey
> Assignee: Eric Maynard
> Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.2.7, 1.3.3, 1.4.5
>
> Attachments: HBASE-20665.master.001.patch,
> HBASE-20665.master.001.patch
>
>
> Testing a local cluster that relies on the LruBlockCache for a scan-heavy
> workload and I'm getting a bunch of log entries at WARN
> {code}
> 2018-05-30 12:28:47,192 WARN org.apache.hadoop.hbase.io.hfile.LruBlockCache:
> Cached an already cached block: df01f5bf6a244f6bb1a626b927377fff_54780812
> cb:df01f5bf6a244f6bb1a626b927377fff_54780812. This is harmless and can happen
> in rare cases (see HBASE-8547)
> {code}
> As the log message notes (and the code confirms) this is a harmless result of
> contention for getting a block into the CHM. the message should be at DEBUG.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
