[ 
https://issues.apache.org/jira/browse/HBASE-4991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214332#comment-13214332
 ] 

stack commented on HBASE-4991:
------------------------------

bq. Do you need tablename, startkey, endkey? Can't you just pass region name?

Again, you may be trying to not reveal region type in API but then 
delete_region would be different to close_region which takes a regionname IIRC?

bq. ..but client does not know the tableName for a regionName in our case...

It does not know?  I may be missing context.  If I am, ignore this comment.  If 
it did know, could use:  'List<HRegionInfo>     getOnlineRegions() '  HRIs have 
tablename.  Could figure it client-side.  You can't use the List<HRegion> 
because we can't serialize HRegion to pass over connection... that call is if 
you are running in same context in JSP or in a unit test or something.

bq. Design choice is like HBASE-4213, meaning master create a znode under 
<zookeeper.znode.parent>/delete-region....

Fair enough.  Will we have a new dir in zk per cluster region operation we want 
to do?  Can we not exploit primitives added by hbase-4213?  Or do we need to 
refactor hbase-4213 to get you primitives you need to do this facility?  Or is 
there nothing in common w/ what hbase-4213 does (there is at least the closing 
of a region?)

bq. ...If we are considering delete_region as a tool/util then we can refactor 
as a tool/util as like Online/Offline merge code....

online merge should have a bunch of overlap w/ this feature?  Would be great if 
they could share a bunch of code/primitives.  As has been suggested, rather 
than a /delete-region, instead we'd have a log of intent+log of actions thing 
up in zk I suppose.  The log of intent would list the steps to be done and then 
the log of actions thingy would log how far the operation had gone (I should 
read up on the cited accumulo doo-hickey).

bq. We do put all our ZK trackers in zookeeper package and this is how online 
schema change HBASE-4213 was implemented.

Thats a bit broken in my opinion.  Its wonky having zk have reference out to 
other main packages.  Not your fault.  Should have caught that in review of 
hbase-4213.

Good on you Mubarak.
                
> Provide capability to delete named region
> -----------------------------------------
>
>                 Key: HBASE-4991
>                 URL: https://issues.apache.org/jira/browse/HBASE-4991
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Mubarak Seyed
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4991.trunk.v1.patch, HBASE-4991.trunk.v2.patch
>
>
> See discussion titled 'Able to control routing to Solr shards or not' on 
> lily-discuss
> User may want to quickly dispose of out of date records by deleting specific 
> regions. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to