[
https://issues.apache.org/jira/browse/HBASE-20635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511479#comment-16511479
]
stack commented on HBASE-20635:
-------------------------------
We might have to amend hbase-protocol pbs... that'd be ok though I think.
I'm just concerned if phoenix is moving to use our internal pbs, our internal
shaded third-party libs, etc. We've done a bunch of work in hbase2 to try and
insulate CPs from our internals. It is not always clear where the boundary is.
We tried to do writeup in the refguide and in code comments but I understand
this may not always be enough getting the message across.
> Support to convert the shaded user permission proto to client user permission
> object
> ------------------------------------------------------------------------------------
>
> Key: HBASE-20635
> URL: https://issues.apache.org/jira/browse/HBASE-20635
> Project: HBase
> Issue Type: Bug
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Priority: Major
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20635.patch, HBASE-20635_v2.patch,
> PHOENIX-4528_5.x-HBase-2.0_v2.patch
>
>
> Currently we have API to build the protobuf UserPermission to client user
> permission in AccessControlUtil but we cannot do the same when we use shaded
> protobufs.
> {noformat}
> /**
> * Converts a user permission proto to a client user permission object.
> *
> * @param proto the protobuf UserPermission
> * @return the converted UserPermission
> */
> public static UserPermission
> toUserPermission(AccessControlProtos.UserPermission proto) {
> return new UserPermission(proto.getUser().toByteArray(),
> toTablePermission(proto.getPermission()));
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
