[ 
https://issues.apache.org/jira/browse/HBASE-20635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520559#comment-16520559
 ] 

stack commented on HBASE-20635:
-------------------------------

bq. Actually I am able to get the user permissions without using internals so 
It's ok to revert in case if it's unnecessary.

You understand the difference between hbase-protocol and hbase-protocol-shaded 
and that the shaded utils are for internal use only?

If so, we can re-resolve this issue. Can just leave the commit in place as long 
as the message about the difference between internal and external, shaded vs 
non-shaded made it across.

> Support to convert the shaded user permission proto to client user permission 
> object
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-20635
>                 URL: https://issues.apache.org/jira/browse/HBASE-20635
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>            Priority: Major
>             Fix For: 3.0.0, 2.1.0
>
>         Attachments: HBASE-20635.patch, HBASE-20635_v2.patch, 
> PHOENIX-4528_5.x-HBase-2.0_v2.patch
>
>
> Currently we have API to build the protobuf UserPermission to client user 
> permission in AccessControlUtil but we cannot do the same when we use shaded 
> protobufs.
> {noformat}
>   /**
>    * Converts a user permission proto to a client user permission object.
>    *
>    * @param proto the protobuf UserPermission
>    * @return the converted UserPermission
>    */
>   public static UserPermission 
> toUserPermission(AccessControlProtos.UserPermission proto) {
>     return new UserPermission(proto.getUser().toByteArray(),
>         toTablePermission(proto.getPermission()));
>   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to