[ 
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516676#comment-16516676
 ] 

stack commented on HBASE-20642:
-------------------------------

Doing nonce creation outside the call method is what makes it so we don't make 
a new nonce on each invocation?

345             Long nonceGroup = ng.getNonceGroup();
346             Long nonce = ng.newNonce();

If so thank you for fixing a bunch of mangled calls.

Bit of doc for this...
  public interface StepHook{ 
?

So, the patch here makes it so call could complete even though Master was 
restarted while call was going on (as long as new Master came up before 
timeout)?

Patch looks good to me [~an...@apache.org]  Nice work sir. I learned/re-learned 
stuff reviewing this work. Thanks.

> IntegrationTestDDLMasterFailover throws 'InvalidFamilyOperationException 
> -------------------------------------------------------------------------
>
>                 Key: HBASE-20642
>                 URL: https://issues.apache.org/jira/browse/HBASE-20642
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Major
>         Attachments: HBASE-20642.001.patch, HBASE-20642.patch
>
>
> [~romil.choksi] reported that IntegrationTestDDLMasterFailover is failing 
> while adding column family during the time master is restarting.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to