[ 
https://issues.apache.org/jira/browse/HBASE-20642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517810#comment-16517810
 ] 

Ankit Singhal commented on HBASE-20642:
---------------------------------------

Thanks [~stack] and [~elserj] for all the help in getting this fixed.
{quote}Doing nonce creation outside the call method is what makes it so we 
don't make a new nonce on each invocation?
{quote}
Yes , so that call method will be called with the same nonce for retries.
{quote}So, the patch here makes it so call could complete even though Master 
was restarted while call was going on (as long as new Master came up before 
timeout)?
{quote}
Yes , the test restarts procedure executor after every step to simulate the 
master failure.
{quote}Bit of doc for this...
 public interface StepHook{ 
 ?
{quote}
Done in the latest patch. Fixed javac, whitespace and checkstyle warning as 
well.
{quote}I learned/re-learned stuff reviewing this work.
{quote}
Same here, great learnings for me as well.

> IntegrationTestDDLMasterFailover throws 'InvalidFamilyOperationException 
> -------------------------------------------------------------------------
>
>                 Key: HBASE-20642
>                 URL: https://issues.apache.org/jira/browse/HBASE-20642
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Major
>         Attachments: HBASE-20642.001.patch, HBASE-20642.002.patch, 
> HBASE-20642.patch
>
>
> [~romil.choksi] reported that IntegrationTestDDLMasterFailover is failing 
> while adding column family during the time master is restarting.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to