[
https://issues.apache.org/jira/browse/HBASE-20732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517898#comment-16517898
]
Chia-Ping Tsai commented on HBASE-20732:
----------------------------------------
Q1:
{code:java}
+ public static void shutDownChorePool() {
+ POOL.shutDownNow();
+ }{code}
Since this method is called by HMaster#stopServiceThreads, it should have null
check and reset the POOL to null. HMaster may fail before calling
#initChorePool.
Q2: Why we have to do a large change to the test cases? the change to
production code is only that we do the shutdown of poll in closing master,
right?
> Shutdown scan pool when master is stopped.
> ------------------------------------------
>
> Key: HBASE-20732
> URL: https://issues.apache.org/jira/browse/HBASE-20732
> Project: HBase
> Issue Type: Bug
> Reporter: Reid Chan
> Assignee: Reid Chan
> Priority: Minor
> Attachments: HBASE-20732.master.001.patch,
> HBASE-20732.master.002.patch
>
>
> If master is stopped, {{DirScanPool}} is kept open. This is found by
> [~chia7712] when reviewing HBASE-20352.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
