[
https://issues.apache.org/jira/browse/HBASE-20732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517918#comment-16517918
]
Reid Chan commented on HBASE-20732:
-----------------------------------
bq. Why we have to do a large change to the test cases?
i found {{TestCleanChore}} was not stable(QA result was different from local
result) and became flaky(sometime failed) when
{{CleanerChore.shutDownChorePool()}} was added, so i did a bit refactor.
bq. the change to production code is only that we do the shutdown of poll in
closing master, right?
Yes, you're right.
Will upload a patch to address Q1.
> Shutdown scan pool when master is stopped.
> ------------------------------------------
>
> Key: HBASE-20732
> URL: https://issues.apache.org/jira/browse/HBASE-20732
> Project: HBase
> Issue Type: Bug
> Reporter: Reid Chan
> Assignee: Reid Chan
> Priority: Minor
> Attachments: HBASE-20732.master.001.patch,
> HBASE-20732.master.002.patch
>
>
> If master is stopped, {{DirScanPool}} is kept open. This is found by
> [~chia7712] when reviewing HBASE-20352.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
