[
https://issues.apache.org/jira/browse/HBASE-20789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524184#comment-16524184
]
Zach York commented on HBASE-20789:
-----------------------------------
Sorry the comment wasn't updated, I think I had updated the comment locally,
but it must not have been pushed out.
Basically there are 3 cases here:
equality (0) -> these blocks are exactly the same, no issue.
(-1) -> The existing block has nextBlockOnDiskSize set so we will get
performance gains by keeping that version.
(1) -> The new block has nextBlockOnDiskSize set so it makes sense to cache the
new version
Please let me know if anything is unclear, I can try to clear it up and I can
try to improve this logging.
Where is the test failing? AFAIK there shouldn't be much flakiness in this
test, but let's fix it if there is.
Thanks for digging in!
> TestBucketCache#testCacheBlockNextBlockMetadataMissing is flaky
> ---------------------------------------------------------------
>
> Key: HBASE-20789
> URL: https://issues.apache.org/jira/browse/HBASE-20789
> Project: HBase
> Issue Type: Bug
> Reporter: Zheng Hu
> Assignee: Zheng Hu
> Priority: Major
>
> The UT failed frequently in our internal branch-2... Will dig into the UT.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
