[
https://issues.apache.org/jira/browse/HBASE-20789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524503#comment-16524503
]
Zheng Hu commented on HBASE-20789:
----------------------------------
bq. The existing block has nextBlockOnDiskSize set so we will get performance
gains by keeping that version.
If the existingBlock has nextBlockOnDiskSize set , while cachedItem has
nextBlockOnDiskSize(default = -1) unset, the comparison should be positive
number ?
So there is a typo ?
{code}
if (cb != null) {
int comparison = BlockCacheUtil.validateBlockAddition(cb.getBuffer(),
buf, cacheKey);
if (comparison != 0) {
- if (comparison < 0) {
+ if (comparison > 0) {
LOG.warn("Cached block contents differ by nextBlockOnDiskSize.
Keeping cached block.");
return;
} else {
{code}
> TestBucketCache#testCacheBlockNextBlockMetadataMissing is flaky
> ---------------------------------------------------------------
>
> Key: HBASE-20789
> URL: https://issues.apache.org/jira/browse/HBASE-20789
> Project: HBase
> Issue Type: Bug
> Reporter: Zheng Hu
> Assignee: Zheng Hu
> Priority: Major
> Attachments: bucket-33718.out
>
>
> The UT failed frequently in our internal branch-2... Will dig into the UT.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
