[ 
https://issues.apache.org/jira/browse/HBASE-20791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524542#comment-16524542
 ] 

Reid Chan commented on HBASE-20791:
-----------------------------------

{code:title=HMaster#finishActiveMasterInitialization, this.balancer is 
RSGroupBasedLoadBalancer}
    // initialize load balancer
    this.balancer.setMasterServices(this);
    this.balancer.setClusterMetrics(getClusterMetricsWithoutCoprocessor());
    this.balancer.initialize();
{code}
internalBalancer(StochasticLoadBalancer) is initialized in method 
{{initialize()}}, and in following code
{code:title=RSGroupBasedLoadBalancer#initialize}
    internalBalancer.setMasterServices(masterServices);
    internalBalancer.setClusterMetrics(clusterStatus);
    internalBalancer.setConf(config);
    internalBalancer.initialize();
{code}
StochasticLoadBalancer must accept the {{clusterStatus}} which set by 
RSGroupBasedLoadBalancer#setClusterMetrics.

I don't think it an issue, nothing should be fixed.

> RSGroupBasedLoadBalancer#setClusterMetrics should pass ClusterMetrics to it’s 
> internalBalancer
> ----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-20791
>                 URL: https://issues.apache.org/jira/browse/HBASE-20791
>             Project: HBase
>          Issue Type: Bug
>          Components: rsgroup
>    Affects Versions: 3.0.0, 2.0.0
>            Reporter: chenxu
>            Assignee: chenxu
>            Priority: Major
>         Attachments: HBASE-20791-master-v1.patch
>
>
> RSGroupBasedLoadBalancer#setClusterMetrics should pass ClusterMetrics to it’s 
> internalBalancer, Or the StochasticLoadBalancer(internal balancer) will lose 
> it's Up-to-date RegionLoads info, and effect the balance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to