[
https://issues.apache.org/jira/browse/HBASE-20791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525771#comment-16525771
]
Ted Yu commented on HBASE-20791:
--------------------------------
I did a search under hbase-server/src/test/ and found the following classes
whose names end in Base:
{code}
hbase-server/src/test//java/org/apache/hadoop/hbase/AcidGuaranteesTestBase.java
hbase-server/src/test//java/org/apache/hadoop/hbase/client/TestAsyncAdminBase.java
hbase-server/src/test//java/org/apache/hadoop/hbase/master/balancer/BalancerTestBase.java
hbase-server/src/test//java/org/apache/hadoop/hbase/master/procedure/TestTableDDLProcedureBase.java
hbase-server/src/test//java/org/apache/hadoop/hbase/replication/SerialReplicationTestBase.java
hbase-server/src/test//java/org/apache/hadoop/hbase/replication/TestReplicationBase.java
hbase-server/src/test//java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsWithDeletesTestBase.java
hbase-server/src/test//java/org/apache/hadoop/hbase/TimestampTestBase.java
hbase-server/src/test//java/org/apache/hadoop/hbase/util/MultiThreadedWriterBase.java
{code}
I think the previous naming with TestBase is Okay.
There is no need to change the naming again (from patch v3).
Please address checkstyle warning and it should be good to go.
> RSGroupBasedLoadBalancer#setClusterMetrics should pass ClusterMetrics to it’s
> internalBalancer
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-20791
> URL: https://issues.apache.org/jira/browse/HBASE-20791
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
> Affects Versions: 3.0.0, 2.0.0
> Reporter: chenxu
> Assignee: chenxu
> Priority: Major
> Attachments: 20791-master-v2.patch, HBASE-20791-master-v1.patch,
> HBASE-20791-master-v3.patch
>
>
> RSGroupBasedLoadBalancer#setClusterMetrics should pass ClusterMetrics to it’s
> internalBalancer, Or the StochasticLoadBalancer(internal balancer) will lose
> it's Up-to-date RegionLoads info, and effect the balance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
