[
https://issues.apache.org/jira/browse/HBASE-20812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528978#comment-16528978
]
Chia-Ping Tsai commented on HBASE-20812:
----------------------------------------
LGTM. The patch inspire me that #incrementColumnValue can be implemented by
#increment.
{code:java}
+ CheckAndMutateBuilder builder = checkAndMutate(row, family);
+ return builder.qualifier(qualifier).ifEquals(value).thenDelete(delete);{code}
Perhaps the local variable can be eliminated... Make it more "fluent":)
> Add defaults to Table Interface so implementors don't have to
> -------------------------------------------------------------
>
> Key: HBASE-20812
> URL: https://issues.apache.org/jira/browse/HBASE-20812
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Major
> Fix For: 3.0.0, 2.1.0, 2.0.2
>
> Attachments:
> 0001-HBASE-20812-Add-defaults-to-Table-Interface-so-imple.patch, 20812.txt,
> HBASE-20812.branch-2.0.001.patch, HBASE-20812.branch-2.0.002.patch,
> HBASE-20812.branch-2.0.003.patch
>
>
> Lets add default implementaitons -- even if they are just throw
> NotImplementedException -- to our Table Interface now we are up on jdk8.
> Table implementations are how the likes of hbase-indexer modify hbase --via
> a publically supported API -- and I notice that the kafka proxy now goes the
> same route. Typically, these customizations are only interested in one or two
> methods of Table adding in their own implementations but they have to supply
> implementations for all Table methods in their override. Lets help them out
> by adding defaults (I had a patch but lost it...).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
