[
https://issues.apache.org/jira/browse/HBASE-20884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543610#comment-16543610
]
Hadoop QA commented on HBASE-20884:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
29s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
23s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
26s{color} | {color:green} branch-1 passed with JDK v1.8.0_172 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
51s{color} | {color:green} branch-1 passed with JDK v1.7.0_181 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
8s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
9s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
9s{color} | {color:green} branch-1 passed with JDK v1.8.0_172 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
2s{color} | {color:green} branch-1 passed with JDK v1.7.0_181 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
57s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
19s{color} | {color:red} hbase-rest in the patch failed with JDK v1.8.0_172.
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 19s{color}
| {color:red} hbase-rest in the patch failed with JDK v1.8.0_172. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
21s{color} | {color:red} hbase-client in the patch failed with JDK v1.7.0_181.
{color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
31s{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_181.
{color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
24s{color} | {color:red} hbase-thrift in the patch failed with JDK v1.7.0_181.
{color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
20s{color} | {color:red} hbase-rest in the patch failed with JDK v1.7.0_181.
{color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
18s{color} | {color:red} hbase-examples in the patch failed with JDK
v1.7.0_181. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 21s{color}
| {color:red} hbase-client in the patch failed with JDK v1.7.0_181. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 31s{color}
| {color:red} hbase-server in the patch failed with JDK v1.7.0_181. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 24s{color}
| {color:red} hbase-thrift in the patch failed with JDK v1.7.0_181. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 20s{color}
| {color:red} hbase-rest in the patch failed with JDK v1.7.0_181. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 18s{color}
| {color:red} hbase-examples in the patch failed with JDK v1.7.0_181. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
29s{color} | {color:red} hbase-common: The patch generated 1 new + 27 unchanged
- 1 fixed = 28 total (was 28) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} The patch hbase-client passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
26s{color} | {color:green} hbase-server: The patch generated 0 new + 104
unchanged - 1 fixed = 104 total (was 105) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} The patch hbase-thrift passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
30s{color} | {color:red} hbase-rest: The patch generated 8 new + 121 unchanged
- 8 fixed = 129 total (was 129) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} The patch hbase-examples passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 1m
10s{color} | {color:red} patch has 28 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m
49s{color} | {color:red} The patch causes 28 errors with Hadoop v2.7.4. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
6s{color} | {color:green} the patch passed with JDK v1.8.0_172 {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
44s{color} | {color:red} hbase-server-jdk1.7.0_181 with JDK v1.7.0_181
generated 5 new + 3 unchanged - 0 fixed = 8 total (was 3) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
45s{color} | {color:red} hbase-thrift-jdk1.7.0_181 with JDK v1.7.0_181
generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
23s{color} | {color:red} hbase-rest-jdk1.7.0_181 with JDK v1.7.0_181 generated
2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
21s{color} | {color:red} hbase-examples-jdk1.7.0_181 with JDK v1.7.0_181
generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
45s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 22s{color}
| {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 30s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 24s{color}
| {color:red} hbase-thrift in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 21s{color}
| {color:red} hbase-rest in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 18s{color}
| {color:red} hbase-examples in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
54s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 39s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:1f3957d |
| JIRA Issue | HBASE-20884 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12931581/HBASE-20884.branch-1.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d170af9826b8 4.4.0-130-generic #156-Ubuntu SMP Thu Jun 14
08:53:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-1 / 3835f71 |
| maven | version: Apache Maven 3.0.5 |
| Default Java | 1.7.0_181 |
| Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_172
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_181 |
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-mvninstall-root.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-compile-hbase-rest-jdk1.8.0_172.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-compile-hbase-rest-jdk1.8.0_172.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-compile-hbase-client-jdk1.7.0_181.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-compile-hbase-server-jdk1.7.0_181.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-compile-hbase-thrift-jdk1.7.0_181.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-compile-hbase-rest-jdk1.7.0_181.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-compile-hbase-examples-jdk1.7.0_181.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-compile-hbase-client-jdk1.7.0_181.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-compile-hbase-server-jdk1.7.0_181.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-compile-hbase-thrift-jdk1.7.0_181.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-compile-hbase-rest-jdk1.7.0_181.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-compile-hbase-examples-jdk1.7.0_181.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/diff-checkstyle-hbase-common.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/diff-checkstyle-hbase-rest.txt
|
| shadedjars |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-shadedjars.txt
|
| hadoopcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-javac-2.7.4.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.7.0_181.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/diff-javadoc-javadoc-hbase-thrift-jdk1.7.0_181.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/diff-javadoc-javadoc-hbase-rest-jdk1.7.0_181.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/diff-javadoc-javadoc-hbase-examples-jdk1.7.0_181.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-unit-hbase-client.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-unit-hbase-thrift.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-unit-hbase-rest.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/artifact/patchprocess/patch-unit-hbase-examples.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/testReport/ |
| Max. process+thread count | 182 (vs. ulimit of 10000) |
| modules | C: hbase-common hbase-client hbase-server hbase-thrift hbase-rest
hbase-examples U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/13621/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Replace usage of our Base64 implementation with java.util.Base64
> ----------------------------------------------------------------
>
> Key: HBASE-20884
> URL: https://issues.apache.org/jira/browse/HBASE-20884
> Project: HBase
> Issue Type: Task
> Reporter: Mike Drob
> Assignee: Mike Drob
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20884.branch-1.001.patch,
> HBASE-20884.master.001.patch
>
>
> We have a public domain implementation of Base64 that is copied into our code
> base and infrequently receives updates. We should replace usage of that with
> the new Java 8 java.util.Base64 where possible.
> For the migration, I propose a phased approach.
> * Deprecate on 1.x and 2.x to signal to users that this is going away.
> * Replace usages on branch-2 and master with j.u.Base64
> * Delete our implementation of Base64 on master.
> Does this seem in line with our API compatibility requirements?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
