[
https://issues.apache.org/jira/browse/HBASE-20893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546667#comment-16546667
]
Duo Zhang commented on HBASE-20893:
-----------------------------------
There are lots of empty lines in the test, please remove them. And we should
use 'LOG.info("Begin to put data");' instead of LOG.error?
And for the hasRecoveredEdit method, the comment says only default replica can
reach here, but you can not prevent others use this method for non-default
replica as it is public right? So I think here if we do not want to call
getDefaultReplica, then we'd better add an assert here to confirm that no one
use it with non-default replica.
Overall LGTM. +1 after fixing the above problems.
> Data loss if splitting region while ServerCrashProcedure executing
> ------------------------------------------------------------------
>
> Key: HBASE-20893
> URL: https://issues.apache.org/jira/browse/HBASE-20893
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 3.0.0, 2.1.0, 2.0.1
> Reporter: Allan Yang
> Assignee: Allan Yang
> Priority: Major
> Attachments: HBASE-20893.branch-2.0.001.patch,
> HBASE-20893.branch-2.0.002.patch
>
>
> Similar case as HBASE-20878.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
