[
https://issues.apache.org/jira/browse/HBASE-20893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547388#comment-16547388
]
stack commented on HBASE-20893:
-------------------------------
Whats the dataloss scenario here? Children open but somehow they miss
recovered.edits that may have shown up in parent because of an inopportune
crash?
s/hasRecoveredEdit/hasRecoveredEdits/ (add 's')?
nits:
You can drop the WALSplitter from WALSplitte.getSplitEditFilesSorted ?
s/files.size() == 0/files.isEmpty()/
Or change...
565 if (files == null || files.size() == 0) {
566 return false;
567 } else {
568 return true;
569 }
to return files != null && !files.isEmpty();
And yeah, does the test repro the condition?
Thanks [~allan163]
> Data loss if splitting region while ServerCrashProcedure executing
> ------------------------------------------------------------------
>
> Key: HBASE-20893
> URL: https://issues.apache.org/jira/browse/HBASE-20893
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 3.0.0, 2.1.0, 2.0.1
> Reporter: Allan Yang
> Assignee: Allan Yang
> Priority: Major
> Attachments: HBASE-20893.branch-2.0.001.patch,
> HBASE-20893.branch-2.0.002.patch
>
>
> Similar case as HBASE-20878.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
