[
https://issues.apache.org/jira/browse/HBASE-19369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559852#comment-16559852
]
Duo Zhang commented on HBASE-19369:
-----------------------------------
As the builder is introduced in hadoop-2.9 so introduce a hadoop3-compact
module does not make sense...
I think the approach is fine. For the test, I think we could make use of
org.junit.Assume to ignore it if we do not have EC support.
And maybe another problem is that, we sometimes use HFileSystem instead of the
original FileSystem instance in our code, the CommonFSUtils will not use the
builder pattern even if the HFileSystem is just a wrapper of
DistributedFileSystem? For WAL I think it is fine as we will not use
HFileSystem, but is it also safe at other places?
Thanks.
> HBase Should use Builder Pattern to Create Log Files while using WAL on
> Erasure Coding
> --------------------------------------------------------------------------------------
>
> Key: HBASE-19369
> URL: https://issues.apache.org/jira/browse/HBASE-19369
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Alex Leblang
> Assignee: Mike Drob
> Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-19369.master.001.patch,
> HBASE-19369.master.002.patch, HBASE-19369.master.003.patch,
> HBASE-19369.master.004.patch, HBASE-19369.v10.patch, HBASE-19369.v5.patch,
> HBASE-19369.v6.patch, HBASE-19369.v7.patch, HBASE-19369.v8.patch,
> HBASE-19369.v9.patch
>
>
> Right now an HBase instance using the WAL won't function properly in an
> Erasure Coded environment. We should change the following line to use the
> hdfs.DistributedFileSystem builder pattern
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java#L92
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
