[
https://issues.apache.org/jira/browse/HBASE-19369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560085#comment-16560085
]
Mike Drob commented on HBASE-19369:
-----------------------------------
bq. I think the approach is fine. For the test, I think we could make use of
org.junit.Assume to ignore it if we do not have EC support.
good idea, will do this.
bq. CommonFSUtils will not use the builder pattern even if the HFileSystem is
just a wrapper of DistributedFileSystem
yea, i just ran into this when trying to do more tests. I don't think it's an
issue that we have to fix right now though, and the test should fail if we
start using HFileSystem for WALs somewhere because the cluster won't work. I'll
add an explicit configuration to enforce stream capabilities checks and add to
the javadoc that HFileSystem is not supported for those methods.
v11 attached.
> HBase Should use Builder Pattern to Create Log Files while using WAL on
> Erasure Coding
> --------------------------------------------------------------------------------------
>
> Key: HBASE-19369
> URL: https://issues.apache.org/jira/browse/HBASE-19369
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Alex Leblang
> Assignee: Mike Drob
> Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-19369.master.001.patch,
> HBASE-19369.master.002.patch, HBASE-19369.master.003.patch,
> HBASE-19369.master.004.patch, HBASE-19369.v10.patch, HBASE-19369.v11.patch,
> HBASE-19369.v5.patch, HBASE-19369.v6.patch, HBASE-19369.v7.patch,
> HBASE-19369.v8.patch, HBASE-19369.v9.patch
>
>
> Right now an HBase instance using the WAL won't function properly in an
> Erasure Coded environment. We should change the following line to use the
> hdfs.DistributedFileSystem builder pattern
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java#L92
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
