[ https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218714#comment-13218714 ]
jirapos...@reviews.apache.org commented on HBASE-5443: ------------------------------------------------------ bq. On 2012-02-28 23:08:15, Alex Newman wrote: bq. > pom.xml, line 761 bq. > <https://reviews.apache.org/r/4054/diff/1/?file=86002#file86002line761> bq. > bq. > does it make sense to assume protoc is in path? Hadoop requires that. I think HBase can do the same thing too. bq. On 2012-02-28 23:08:15, Alex Newman wrote: bq. > src/main/proto/HRegionProtocol.proto, line 265 bq. > <https://reviews.apache.org/r/4054/diff/1/?file=86003#file86003line265> bq. > bq. > Why would you give a regionname, as opposed to a tablename? The current HRegionInterface uses regionName. It is to lock a row in a region. Otherwise, we need to find which region is the row in. bq. On 2012-02-28 23:08:15, Alex Newman wrote: bq. > src/main/proto/HRegionProtocol.proto, line 174 bq. > <https://reviews.apache.org/r/4054/diff/1/?file=86003#file86003line174> bq. > bq. > if the region is bq. > bq. > foo,bar,1234.4567. bq. > bq. > Then the encoded name is 4567? no? That's right. The encoded name is the hash. - Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4054/#review5416 ----------------------------------------------------------- On 2012-02-27 18:54:31, Jimmy Xiang wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/4054/ bq. ----------------------------------------------------------- bq. bq. (Updated 2012-02-27 18:54:31) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. ------- bq. bq. This is the first draft of the ProtoBuff HRegionProtocol. The corresponding java vs pb method mapping is attached to the jira: https://issues.apache.org/jira/browse/HBASE-5443 bq. bq. Please review. I'd like to move ahead after we get to some agreement. bq. bq. bq. This addresses bug HBASE-5443. bq. https://issues.apache.org/jira/browse/HBASE-5443 bq. bq. bq. Diffs bq. ----- bq. bq. pom.xml 066c027 bq. src/main/proto/HRegionProtocol.proto PRE-CREATION bq. src/main/proto/hbase.proto PRE-CREATION bq. bq. Diff: https://reviews.apache.org/r/4054/diff bq. bq. bq. Testing bq. ------- bq. bq. bq. Thanks, bq. bq. Jimmy bq. bq. > Add PB-based calls to HRegionInterface > -------------------------------------- > > Key: HBASE-5443 > URL: https://issues.apache.org/jira/browse/HBASE-5443 > Project: HBase > Issue Type: Sub-task > Components: ipc, master, migration, regionserver > Reporter: Todd Lipcon > Assignee: Jimmy Xiang > Fix For: 0.96.0 > > Attachments: region_java-proto-mapping.pdf > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira