[
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221085#comment-13221085
]
[email protected] commented on HBASE-5443:
------------------------------------------------------
bq. On 2012-03-02 10:30:06, Benoit Sigoure wrote:
bq. > This seems to be close to a one-to-one mapping with the current
interface today. I don't know if this is the intent or whether you're willing
to completely redesign the look of the API too. Maybe it's to ease the
transition?
bq. >
bq. > I'd like to see a request type to do one-shot scans. Something where
you don't even get a scanner ID. You pass parameters like to open a scanner,
you say up to how many rows or bytes you want to retrieve, and you get just
that in one shot.
bq. > When opening a actual scanner, we also need to be able to get the first
batch of scan results at the same time we open the scanner. This is a
must-have IMO. And we need to be able to request to close the scanner while
fetching a batch of results.
bq. >
bq. > It would be nice to have a "keep-alive" request for existing scanners.
Something to tell the server "I'm not fetching anything from this scanner right
now, but please keep it open by reseting its TTL, don't close it just because I
haven't used it for a while".
bq. >
bq. > Please, please, please, consider shortening the name of all these
protobufs and dropping the Proto suffix. The current names are unnecessarily
long or aren't intuitive (e.g. "columnFamily" for something that describes the
multiple things you're trying to get out of a row) or are too redundant (e.g.
"KeyType keyType").
bq. >
bq. > Regarding the lack of "multi" RPC, I think this is a good thing.
"multi" is a big mess that was only marginally better than its horrible
"multiPut" predecessor. This proposal already supports multi-everything, it
just doesn't support batching different kind of operations in the same RPC,
which isn't a big deal IMO.
We should implement what Benoît is asking for, probably not all as part of this
issue. That said, if possible can we try and accomodate what he's asking for
down here at the rpc level? I suppose once all is pb, it should be easy enough
adding new stuff but it would be good to keep in mind what he's asking while
redoing this layer. In a later issue we can add the overloads that exploit the
additions or add the new methods B wants (What B is asking for are long-time
outstanding fixups needed in hbase). For example, can the pb response on open
of a scanner be more than just the scanner id; could it include an optional
result item? Or I suppose, once up on pb, we can do this easily enough later?
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5552
-----------------------------------------------------------
On 2012-02-27 18:54:31, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4054/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-27 18:54:31)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is the first draft of the ProtoBuff HRegionProtocol. The
corresponding java vs pb method mapping is attached to the jira:
https://issues.apache.org/jira/browse/HBASE-5443
bq.
bq. Please review. I'd like to move ahead after we get to some agreement.
bq.
bq.
bq. This addresses bug HBASE-5443.
bq. https://issues.apache.org/jira/browse/HBASE-5443
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. pom.xml 066c027
bq. src/main/proto/HRegionProtocol.proto PRE-CREATION
bq. src/main/proto/hbase.proto PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4054/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Add PB-based calls to HRegionInterface
> --------------------------------------
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Todd Lipcon
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
