[
https://issues.apache.org/jira/browse/HBASE-20981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565983#comment-16565983
]
stack commented on HBASE-20981:
-------------------------------
Excellent. Thank you for working on this [~jackbearden].
FYI, we usually annotate data members or methods we give more visibility to
just so we can better test with @VisibleForTesting. For the next time. Its
kinda useless, just a pallative, but it does give a bit of signal that only
testers should be using methods denoted so.
+1 on patch from me. Nice test. I could commit and fix checkstyle on commit but
lets see if [~allan163] has any input... otherwise I'll commit tomorrow. Thanks.
> Rollback stateCount accounting thrown-off when exception out of rollbackState
> -----------------------------------------------------------------------------
>
> Key: HBASE-20981
> URL: https://issues.apache.org/jira/browse/HBASE-20981
> Project: HBase
> Issue Type: Bug
> Components: amv2
> Affects Versions: 2.0.1
> Reporter: stack
> Assignee: Jack Bearden
> Priority: Major
> Fix For: 2.0.2
>
> Attachments: HBASE-20981.002.patch, HBASE-20981.branch-2.001.patch
>
>
> Found by might [~allan163] over in HBASE-20893. Quoting Allan:
> {code}
> But, there is truly a bug here,
> @Override
> protected void rollback(final TEnvironment env)
> throws IOException, InterruptedException {
> if (isEofState()) stateCount--;
> try {
> updateTimestamp();
> rollbackState(env, getCurrentState());
> stateCount--;
> } finally {
> updateTimestamp();
> }
> }
> We need to decrease the stateCount when rolling back, so we can rollback for
> the previous state correctly. But. since a exception is thrown, the decrease
> for stateCount never happen. So ProcedureExecutor will continue to rollback
> for only one state(the one throw a exception) until the end of the execution
> stack.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
