[ 
https://issues.apache.org/jira/browse/HBASE-20981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577405#comment-16577405
 ] 

Hudson commented on HBASE-20981:
--------------------------------

Results for branch branch-2.0
        [build #663 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/663/]: 
(x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/663//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/663//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/663//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Rollback stateCount accounting thrown-off when exception out of rollbackState
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-20981
>                 URL: https://issues.apache.org/jira/browse/HBASE-20981
>             Project: HBase
>          Issue Type: Bug
>          Components: amv2
>    Affects Versions: 2.0.1
>            Reporter: stack
>            Assignee: Jack Bearden
>            Priority: Major
>             Fix For: 3.0.0, 2.0.2, 2.1.1
>
>         Attachments: HBASE-20981.002.patch, HBASE-20981.branch-2.001.patch
>
>
> Found by might [~allan163] over in HBASE-20893. Quoting Allan:
> {code}
> But, there is truly a bug here,
>   @Override
>   protected void rollback(final TEnvironment env)
>       throws IOException, InterruptedException {
>     if (isEofState()) stateCount--;
>     try {
>       updateTimestamp();
>       rollbackState(env, getCurrentState());
>       stateCount--;
>     } finally {
>       updateTimestamp();
>     }
>   }
> We need to decrease the stateCount when rolling back, so we can rollback for 
> the previous state correctly. But. since a exception is thrown, the decrease 
> for stateCount never happen. So ProcedureExecutor will continue to rollback 
> for only one state(the one throw a exception) until the end of the execution 
> stack.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to