[
https://issues.apache.org/jira/browse/HBASE-20856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566480#comment-16566480
]
Zach York commented on HBASE-20856:
-----------------------------------
[~reidchan] I asked [~taklwu] to use PRs to review his code as, in my opinion,
it is simpler to create, review, and push commits from a PR (and [~busbey] had
tipped me off that the QA bot should work with PRs). I'd be happy to discuss
with you further on why I think it makes sense to utilize PRs, but that's not
really the original intent here.
Thanks for the insight on closing PRs. I will take that into account in the
future.
[~taklwu] can you please close the PRs for this issue to avoid having to ammend
the commit (it's already pushed).
> PITA having to set WAL provider in two places
> ---------------------------------------------
>
> Key: HBASE-20856
> URL: https://issues.apache.org/jira/browse/HBASE-20856
> Project: HBase
> Issue Type: Improvement
> Components: Operability, wal
> Affects Versions: 3.0.0
> Reporter: stack
> Assignee: Tak Lon (Stephen) Wu
> Priority: Minor
> Fix For: 3.0.0, 2.0.2, 2.2.0, 2.1.1
>
> Attachments: HBASE-20856.branch-2.001.patch,
> HBASE-20856.branch-2.002.patch, HBASE-20856.master.001.patch,
> HBASE-20856.master.002.patch, HBASE-20856.master.003.patch
>
>
> Courtesy of [~elserj], I learn that changing WAL we need to set two places...
> both hbase.wal.meta_provider and hbase.wal.provider. Operator should only
> have to set it in one place; hbase.wal.meta_provider should pick up general
> setting unless hbase.wal.meta_provider is explicitly set.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
