[
https://issues.apache.org/jira/browse/HBASE-20856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567433#comment-16567433
]
Zach York commented on HBASE-20856:
-----------------------------------
[~reidchan] In the how to close Github PRs, it suggests that people are free to
use PRs if they wish. I do think it could use some more docs. Let me make sure
the QA bot part of it works and then I'll write up a section. Thanks for the
suggestion!
Here's the section on PR preference in the book:
As a project we work to ensure there’s a JIRA associated with each change, but
we don’t mandate any particular tool be used for reviews. Due to implementation
details of the ASF’s integration between hosted git repositories and GitHub,
the PMC has no ability to directly close PRs on our GitHub repo. In the event
that a contributor makes a Pull Request on GitHub, either because the
contributor finds that easier than attaching a patch to JIRA or because a
reviewer prefers that UI for examining changes, it’s important to make note of
the PR in the commit that goes to the master branch so that PRs are kept up to
date.
> PITA having to set WAL provider in two places
> ---------------------------------------------
>
> Key: HBASE-20856
> URL: https://issues.apache.org/jira/browse/HBASE-20856
> Project: HBase
> Issue Type: Improvement
> Components: Operability, wal
> Affects Versions: 3.0.0
> Reporter: stack
> Assignee: Tak Lon (Stephen) Wu
> Priority: Minor
> Fix For: 3.0.0, 2.0.2, 2.2.0, 2.1.1
>
> Attachments: HBASE-20856.branch-2.001.patch,
> HBASE-20856.branch-2.002.patch, HBASE-20856.master.001.patch,
> HBASE-20856.master.002.patch, HBASE-20856.master.003.patch
>
>
> Courtesy of [~elserj], I learn that changing WAL we need to set two places...
> both hbase.wal.meta_provider and hbase.wal.provider. Operator should only
> have to set it in one place; hbase.wal.meta_provider should pick up general
> setting unless hbase.wal.meta_provider is explicitly set.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
