[
https://issues.apache.org/jira/browse/HBASE-20704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571977#comment-16571977
]
Francis Liu commented on HBASE-20704:
-------------------------------------
{quote}The v4 patch looks like the right thing to do, IMHO.
{quote}
Sounds good will go with this then.
{quote}This test isn't actually waiting for anything to happen, right?
{{store.closeAndArchiveCompactedFiles(true);}}completed all actions at that
step. Or otherwise this could flake.
{quote}
If you're talking about that particular section. It's just making sure that
we're getting IOExceptions (ie isntead of NPEs or not at all) which confirms
that the listener hook is working and our expectations on the type of exception
(IOException is thrown).
Let me clean this up then and put it on RB. Thanks for getting back to it.
> Sometimes some compacted storefiles are not archived on region close
> --------------------------------------------------------------------
>
> Key: HBASE-20704
> URL: https://issues.apache.org/jira/browse/HBASE-20704
> Project: HBase
> Issue Type: Bug
> Components: Compaction
> Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-20704.001.patch, HBASE-20704.002.patch,
> HBASE-20704.003.patch, HBASE-20704.004.draft.patch
>
>
> During region close compacted files which have not yet been archived by the
> discharger are archived as part of the region closing process. It is
> important that these files are wholly archived to insure data consistency. ie
> a storefile containing delete tombstones can be archived while older
> storefiles containing cells that were supposed to be deleted are left
> unarchived thereby undeleting those cells.
> On region close a compacted storefile is skipped from archiving if it has
> read references (ie open scanners). This behavior is correct for when the
> discharger chore runs but on region close consistency is of course more
> important so we should add a special case to ignore any references on the
> storefile and go ahead and archive it.
> Attached patch contains a unit test that reproduces the problem and the
> proposed fix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
