[ 
https://issues.apache.org/jira/browse/HBASE-21047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579303#comment-16579303
 ] 

Hadoop QA commented on HBASE-21047:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  3s{color} 
| {color:red} HBASE-21047 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.7.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-21047 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12935483/HBASE-21047.v1.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14033/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Object creation of StoreFileScanner thru constructor and close may leave 
> refCount to -1
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-21047
>                 URL: https://issues.apache.org/jira/browse/HBASE-21047
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Vishal Khandelwal
>            Assignee: Vishal Khandelwal
>            Priority: Major
>             Fix For: 1.5.0
>
>         Attachments: HBASE-21047.v1.patch
>
>
> During object creation  "*StoreFileScanner*", it does not increase the 
> refCount whereas while close it decrements the reader refCount. This will 
> cause refCount to -1 and isReadReference method was returning true 
> (refCount.get() != 0 This is causing store file not to be deleted. This may 
> also cause issue in situation when some thread is holding a scanner but it 
> may actually be closed due to above bug. Impact of this would be really high. 
> Attatching patch for the fix which makes sure if reference is held either 
> thru getScanner method or constructor, ref is always updated. Patch also 
> contains a test which validates the issue. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to