[
https://issues.apache.org/jira/browse/HBASE-21047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580532#comment-16580532
]
Andrew Purtell commented on HBASE-21047:
----------------------------------------
The change looks fine. Unfortunately the precommit had both a surefire and
environmental issue. Let me try running with this change applied locally. As
far as i can tell from the checkstyle report that isn't involved with this
change.
Does this impact branch-2 and master? Or only branch-1? My guess is all. We
will need patches for master at least to commit down the line.
>From an interaction we've had I know this is Phoenix related, needed for local
>indexes to work properly. Is there a Phoenix JIRA for that? If not can you
>file it and link it here?
> Object creation of StoreFileScanner thru constructor and close may leave
> refCount to -1
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-21047
> URL: https://issues.apache.org/jira/browse/HBASE-21047
> Project: HBase
> Issue Type: Bug
> Reporter: Vishal Khandelwal
> Assignee: Vishal Khandelwal
> Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-21047.branch-1.v1.patch
>
>
> During object creation "*StoreFileScanner*", it does not increase the
> refCount whereas while close it decrements the reader refCount. This will
> cause refCount to -1 and isReadReference method was returning true
> (refCount.get() != 0 This is causing store file not to be deleted. This may
> also cause issue in situation when some thread is holding a scanner but it
> may actually be closed due to above bug. Impact of this would be really high.
> Attatching patch for the fix which makes sure if reference is held either
> thru getScanner method or constructor, ref is always updated. Patch also
> contains a test which validates the issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
