[
https://issues.apache.org/jira/browse/HBASE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220219#comment-13220219
]
stack commented on HBASE-5451:
------------------------------
I wonder how Jimmy is doing stuff like the below:
{code}
+import
org.apache.hadoop.hbase.ipc.protobuf.RPCMessageProtos.ConnectionHeaderProto;
+import
org.apache.hadoop.hbase.ipc.protobuf.RPCMessageProtos.RpcRequestWithHeaderProto;
+import
org.apache.hadoop.hbase.ipc.protobuf.RPCMessageProtos.RpcResponseWithHeaderProto;
+import org.apache.hadoop.hbase.ipc.protobuf.RPCMessageProtos.RpcExceptionProto;
+import org.apache.hadoop.hbase.ipc.protobuf.RPCMessageProtos.RpcRequestProto;
+import org.apache.hadoop.hbase.ipc.protobuf.RPCMessageProtos.RpcResponseProto;
{code}
... over in his patch (he's just done the proto stuff so far -- not sure about
what the generated stuff will look like just yet).
We need to have convention around this stuff. Might be worth chat up on dev
list.
For example, I wonder if we need the protobuf package here since all proto
classes are contained in RPCMessageProtos (and its got a suffix to identify it
as proto generated).
The below is a pity but as you say, shouldn't live long:
{code}
+ result.write(d);
+ //makes a copy; but this part of code is not going to live long
+ //hopefully (only until we move all the protocols to protobuf)
+ response.setResponse(ByteString.copyFrom(d.getData()));
{code}
Is that maybeTranslate method repeated?
Exceptions still strings then?
+ response.getException().getStackTrace()));
Looks like your pom edit clashes with Jimmys over in the HRegionInterface redo.
May the first commit win.
The doc on the proto file is great.
This is shaping up nice.
Jimmy, you should review!
> Switch RPC call envelope/headers to PBs
> ---------------------------------------
>
> Key: HBASE-5451
> URL: https://issues.apache.org/jira/browse/HBASE-5451
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Affects Versions: 0.94.0
> Reporter: Todd Lipcon
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: rpc-proto.2.txt, rpc-proto.3.txt, rpc-proto.patch.1_2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
