[
https://issues.apache.org/jira/browse/HBASE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220242#comment-13220242
]
Devaraj Das commented on HBASE-5451:
------------------------------------
bq. For example, I wonder if we need the protobuf package here since all proto
classes are contained in RPCMessageProtos (and its got a suffix to identify it
as proto generated).
Ok. I will go with what everyone thinks. I am pretty unbiased..
bq. Is that maybeTranslate method repeated?
Yes, but with different semantics. Again, these translate methods are required
for the interim only (as long as we have both writable rpc engine and protobuf
rpc engine). Since the protobuf rpc engine is not there yet, we have to always
do the translation.
bq. Exceptions still strings then?
Currently the exceptions are protobuf objs with exception-name and
exception-trace as the fields. I think this is the closest we can get if we
need to support multiple languages on the client side over protobuf. If we have
Java clients, we can do the forname trick to construct an instance of the
exception class and fill up the exception trace, etc. but this can be addressed
in a separate jira. Makes sense?
> Switch RPC call envelope/headers to PBs
> ---------------------------------------
>
> Key: HBASE-5451
> URL: https://issues.apache.org/jira/browse/HBASE-5451
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Affects Versions: 0.94.0
> Reporter: Todd Lipcon
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: rpc-proto.2.txt, rpc-proto.3.txt, rpc-proto.patch.1_2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
