[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594333#comment-16594333
]
Ted Yu commented on HBASE-20734:
--------------------------------
Took a quick look at patch v6.
{code}
+ public HRegionFileSystem getRegionWALFileSystem() throws IOException {
{code}
The above is only used by HRegion and doesn't need to be public.
{code}
+ public Path getWALRegionDir() throws IOException {
+ if (regionDir == null) {
{code}
You use lazy initialization because the field is only used in tests ?
{code}
+ for (Path file: filesUnderRootDir) {
+ if (!rootFS.delete(file, false)) {
+ LOG.error("Failed delete of " + file);
{code}
Probably mention in the log that the file was under root dir.
Once reviewboard is updated, I will review again.
thanks
> Colocate recovered edits directory with hbase.wal.dir
> -----------------------------------------------------
>
> Key: HBASE-20734
> URL: https://issues.apache.org/jira/browse/HBASE-20734
> Project: HBase
> Issue Type: Improvement
> Components: MTTR, Recovery, wal
> Reporter: Ted Yu
> Assignee: Zach York
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20734.branch-1.001.patch,
> HBASE-20734.master.001.patch, HBASE-20734.master.002.patch,
> HBASE-20734.master.003.patch, HBASE-20734.master.004.patch,
> HBASE-20734.master.005.patch, HBASE-20734.master.006.patch
>
>
> During investigation of HBASE-20723, I realized that we wouldn't get the best
> performance when hbase.wal.dir is configured to be on different (fast) media
> than hbase rootdir w.r.t. recovered edits since recovered edits directory is
> currently under rootdir.
> Such setup may not result in fast recovery when there is region server
> failover.
> This issue is to find proper (hopefully backward compatible) way in
> colocating recovered edits directory with hbase.wal.dir .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
