[ 
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599345#comment-16599345
 ] 

Zach York commented on HBASE-20734:
-----------------------------------

[[email protected]] any more comments? Latest diff is up.

 

btw I found a bug with HBASE-20723 where 
[https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java#L1363]
 should actually be rootFs instead of fs. This causes errors to be thrown and 
recovery to not proceed. Given how close (I think) this Jira is, I would prefer 
to just fix it in here (it's already fixed).

 

[~apurtell] [~stack] FYI for your respective releases (although on HBASE-20723 
we decided to not block releases for non-default errors).

> Colocate recovered edits directory with hbase.wal.dir
> -----------------------------------------------------
>
>                 Key: HBASE-20734
>                 URL: https://issues.apache.org/jira/browse/HBASE-20734
>             Project: HBase
>          Issue Type: Improvement
>          Components: MTTR, Recovery, wal
>            Reporter: Ted Yu
>            Assignee: Zach York
>            Priority: Major
>             Fix For: 3.0.0
>
>         Attachments: HBASE-20734.branch-1.001.patch, 
> HBASE-20734.branch-1.002.patch, HBASE-20734.branch-1.003.patch, 
> HBASE-20734.master.001.patch, HBASE-20734.master.002.patch, 
> HBASE-20734.master.003.patch, HBASE-20734.master.004.patch, 
> HBASE-20734.master.005.patch, HBASE-20734.master.006.patch, 
> HBASE-20734.master.007.patch, HBASE-20734.master.008.patch, 
> HBASE-20734.master.009.patch, HBASE-20734.master.010.patch
>
>
> During investigation of HBASE-20723, I realized that we wouldn't get the best 
> performance when hbase.wal.dir is configured to be on different (fast) media 
> than hbase rootdir w.r.t. recovered edits since recovered edits directory is 
> currently under rootdir.
> Such setup may not result in fast recovery when there is region server 
> failover.
> This issue is to find proper (hopefully backward compatible) way in 
> colocating recovered edits directory with hbase.wal.dir .



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to