[
https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605012#comment-16605012
]
Ted Yu commented on HBASE-21138:
--------------------------------
Thanks for the new patch.
Can you take a look at
https://builds.apache.org/job/PreCommit-HBASE-Build/14318/artifact/patchprocess/diff-checkstyle-hbase-server.txt
to see if any warning applies to the modified test ?
> Close HRegion instance at the end of every test in TestHRegion
> --------------------------------------------------------------
>
> Key: HBASE-21138
> URL: https://issues.apache.org/jira/browse/HBASE-21138
> Project: HBase
> Issue Type: Test
> Reporter: Ted Yu
> Assignee: Mingliang Liu
> Priority: Major
> Attachments: HBASE-21138.000.patch, HBASE-21138.001.patch,
> HBASE-21138.002.patch
>
>
> TestHRegion has over 100 tests.
> The following is from one subtest:
> {code}
> public void testCompactionAffectedByScanners() throws Exception {
> byte[] family = Bytes.toBytes("family");
> this.region = initHRegion(tableName, method, CONF, family);
> {code}
> this.region is not closed at the end of the subtest.
> testToShowNPEOnRegionScannerReseek is another example.
> Every subtest should use the following construct toward the end:
> {code}
> } finally {
> HBaseTestingUtility.closeRegionAndWAL(this.region);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
