[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606440#comment-16606440 ]
Hadoop QA commented on HBASE-21138: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color} | {color:red} HBASE-21138 does not apply to branch-2. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.7.0/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HBASE-21138 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12938723/HBASE-21138.branch-2.004.patch | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/14337/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Close HRegion instance at the end of every test in TestHRegion > -------------------------------------------------------------- > > Key: HBASE-21138 > URL: https://issues.apache.org/jira/browse/HBASE-21138 > Project: HBase > Issue Type: Test > Reporter: Ted Yu > Assignee: Mingliang Liu > Priority: Major > Attachments: HBASE-21138.000.patch, HBASE-21138.001.patch, > HBASE-21138.002.patch, HBASE-21138.003.patch, HBASE-21138.004.patch, > HBASE-21138.branch-1.004.patch, HBASE-21138.branch-2.004.patch > > > TestHRegion has over 100 tests. > The following is from one subtest: > {code} > public void testCompactionAffectedByScanners() throws Exception { > byte[] family = Bytes.toBytes("family"); > this.region = initHRegion(tableName, method, CONF, family); > {code} > this.region is not closed at the end of the subtest. > testToShowNPEOnRegionScannerReseek is another example. > Every subtest should use the following construct toward the end: > {code} > } finally { > HBaseTestingUtility.closeRegionAndWAL(this.region); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)