[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609851#comment-16609851
]
Zach York commented on HBASE-20734:
-----------------------------------
[~reidchan] Thanks for the review, sorry I'm slow updating.
{quote}avoid unnecessary style changes like below:
{quote}
Would you prefer I submit a separate patch for style changes? This doesn't
follow Java camel case conventions.
{quote}Don't we add two new reference? i'm not sure about the ref count, what if
{regionDir}
and
{walFS}
never get initialized which may not happen in real world, but it is a logical
problem.
{quote}
Yes, two references were added... I changed this just to fix the TestHeapSize
test, but it should be 53. The reason these are lazy initialized is that
getting the values results in an IOException and I didn't want to change the
constructor of HRegion to throw IOException since it is so widely used. In the
real world this should not be an issue as you mention. What is your suggestion
for this?
> Colocate recovered edits directory with hbase.wal.dir
> -----------------------------------------------------
>
> Key: HBASE-20734
> URL: https://issues.apache.org/jira/browse/HBASE-20734
> Project: HBase
> Issue Type: Improvement
> Components: MTTR, Recovery, wal
> Reporter: Ted Yu
> Assignee: Zach York
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20734.branch-1.001.patch,
> HBASE-20734.branch-1.002.patch, HBASE-20734.branch-1.003.patch,
> HBASE-20734.master.001.patch, HBASE-20734.master.002.patch,
> HBASE-20734.master.003.patch, HBASE-20734.master.004.patch,
> HBASE-20734.master.005.patch, HBASE-20734.master.006.patch,
> HBASE-20734.master.007.patch, HBASE-20734.master.008.patch,
> HBASE-20734.master.009.patch, HBASE-20734.master.010.patch
>
>
> During investigation of HBASE-20723, I realized that we wouldn't get the best
> performance when hbase.wal.dir is configured to be on different (fast) media
> than hbase rootdir w.r.t. recovered edits since recovered edits directory is
> currently under rootdir.
> Such setup may not result in fast recovery when there is region server
> failover.
> This issue is to find proper (hopefully backward compatible) way in
> colocating recovered edits directory with hbase.wal.dir .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
