[
https://issues.apache.org/jira/browse/HBASE-5515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221999#comment-13221999
]
Phabricator commented on HBASE-5515:
------------------------------------
tedyu has commented on the revision "HBASE-5515 [jira] Add a processRow API
that supports atomic multiple reads and writes on a row".
INLINE COMMENTS
src/test/java/org/apache/hadoop/hbase/coprocessor/TestProcessRowEndpoint.java:210
Can we remove the braces for this code block (ending at line 223) ?
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:4318 In the
processor, multiple scans may be performed.
Should we introduce timeout for this invocation ?
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:4368 What if
the wal sync was unsuccessful ?
We should prepare to remove keys from memstore.
See line 2204 of doMiniBatchPut().
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:4364 Does
step 9 have to be in the finally block ?
REVISION DETAIL
https://reviews.facebook.net/D2067
> Add a processRow API that supports atomic multiple reads and writes on a row
> ----------------------------------------------------------------------------
>
> Key: HBASE-5515
> URL: https://issues.apache.org/jira/browse/HBASE-5515
> Project: HBase
> Issue Type: New Feature
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: HBASE-5515.D2067.1.patch, HBASE-5515.D2067.2.patch,
> HBASE-5515.D2067.3.patch, HBASE-5515.D2067.4.patch, HBASE-5515.D2067.5.patch,
> HBASE-5515.D2067.6.patch, HBASE-5515.D2067.7.patch, HBASE-5515.D2067.8.patch
>
>
> We have modified HRegion.java internally to do some atomic row processing. It
> will be nice to have a plugable API for this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
