[
https://issues.apache.org/jira/browse/HBASE-5515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222749#comment-13222749
]
Phabricator commented on HBASE-5515:
------------------------------------
tedyu has commented on the revision "HBASE-5515 [jira] Add a processRow API
that supports atomic multiple reads and writes on a row".
Good progress.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/coprocessor/RowProcessor.java:43 Please
explain type parameter T in javadoc.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:4379
mutations may have many elements.
We should control the length of this log.
src/main/java/org/apache/hadoop/hbase/coprocessor/RowProcessor.java:72 This
method is used for testing.
I suggest making it package private.
Also, walEdits is empty upon entrance to this method.
Do we need to expose it ? It is not used by friends of friends test.
REVISION DETAIL
https://reviews.facebook.net/D2067
> Add a processRow API that supports atomic multiple reads and writes on a row
> ----------------------------------------------------------------------------
>
> Key: HBASE-5515
> URL: https://issues.apache.org/jira/browse/HBASE-5515
> Project: HBase
> Issue Type: New Feature
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: HBASE-5515.D2067.1.patch, HBASE-5515.D2067.10.patch,
> HBASE-5515.D2067.2.patch, HBASE-5515.D2067.3.patch, HBASE-5515.D2067.4.patch,
> HBASE-5515.D2067.5.patch, HBASE-5515.D2067.6.patch, HBASE-5515.D2067.7.patch,
> HBASE-5515.D2067.8.patch, HBASE-5515.D2067.9.patch
>
>
> We have modified HRegion.java internally to do some atomic row processing. It
> will be nice to have a plugable API for this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
