[ 
https://issues.apache.org/jira/browse/HBASE-21270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640547#comment-16640547
 ] 

Allan Yang commented on HBASE-21270:
------------------------------------

For rollback, Throwable is already caught in 'private LockState 
executeRollback(Procedure<TEnvironment> proc) ', the lock will be released 
anyway. so we don't have to catch throwable again in the outside.
For execProcedure, have you encountered a case that an exception is thrown and 
the lock was not released? I think if this is a case here, it is more dangerous 
to release the lock here than just stuck there until we figure out why.


> [amv2] Let go of Procedure entity lock on CODE-BUG or 
> UnsupportedOperationException
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-21270
>                 URL: https://issues.apache.org/jira/browse/HBASE-21270
>             Project: HBase
>          Issue Type: Bug
>          Components: amv2
>            Reporter: stack
>            Priority: Major
>             Fix For: 2.2.0, 2.1.1, 2.0.3
>
>         Attachments: HBASE-21270.branch-2.1.001.patch, 
> HBASE-21270.branch-2.1.002.patch
>
>
> Small patch but helps when we run into ugly bugs... Let go of the entity lock.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to